feat: add split_comma_separated helper for INI-loaded config - #14
Merged
Merged
Conversation
thomas-samoht
marked this pull request as draft
September 8, 2026 08:18
thomas-samoht
marked this pull request as ready for review
September 8, 2026 08:24
ricklambrechts
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps that load
ConfigLogging(or their own config models) from INI-stylefiles need list-typed settings to arrive already split, since pydantic won't
turn a plain string into a list on its own. Several apps started hand-rolling
this identically for
console_streamsafter the v0.3.0 bump.Adds
gfmodules.logging.ini.split_comma_separated(), a small opt-in helperthat builds a pydantic
mode="before"validator for exactly this. Also updated the version for a new release.